Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 #8732

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Support Python 3.12 #8732

merged 5 commits into from
Jan 9, 2024

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jan 8, 2024

This is #8227, with one change on top to make tests pass locally. Checking CI now.

Closes #8348.

dshick-nydig and others added 5 commits January 8, 2024 19:25
Co-authored-by: Dan Shick <dan.shick@nydig.com>
Co-authored-by: Jurre <jurre@github.com>
Co-authored-by: Dan Shick <dan.shick@nydig.com>
Co-authored-by: Jurre <jurre@github.com>
Co-authored-by: Dan Shick <dan.shick@nydig.com>
Co-authored-by: Jurre <jurre@github.com>
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review January 8, 2024 18:26
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner January 8, 2024 18:26
@abdulapopoola
Copy link
Member

[minor]: Do we expect to do public announcements when we add support for new language versions?

cc: @carogalvin

Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@deivid-rodriguez deivid-rodriguez merged commit b7cc2cd into main Jan 9, 2024
93 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/python-3.12 branch January 9, 2024 13:11
@amureki
Copy link
Contributor

amureki commented Jan 15, 2024

Fantastic work, thank you everyone related for maintaining this! 🥇

@dshick-nydig
Copy link
Contributor

@deivid-rodriguez thanks for finishing this one up.

@deivid-rodriguez
Copy link
Contributor Author

Thanks to you for getting most of the job done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
6 participants