grouped security updates: use the group if one is defined #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
changed the title
|
Almost good to go, but the devcontainers smoke test is trying to tell me something is wrong. |
|
Some of the new tests I just merged in are failing, so taking it back to draft. |
jurre
approved these changes
Jan 31, 2024
|
I deployed this PR and saw exceptions where a grouped security update with 1 dependency wasn't getting picked up by the GroupUpdateAllVersions operation. So in 06673bf I swapped the check for an implicit group to be if This will all be cleaned up once the API sends groups! 😓 |
jakecoffman
deleted the
jakecoffman/use-security-group-if-one-is-defined
branch
|
Redeployed and it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed that a grouped security update would just group all of the dependencies passed in the job.
This PR will cause grouped security updates to use the one defined in the job instead.
We can't merge this until the service starts sending groups for these types of jobs.I've updated this to fallback to the old behavior, so it should be mergeable now.