Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode rdbg launch command #8778

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Fix vscode rdbg launch command #8778

merged 5 commits into from
Jan 16, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Jan 12, 2024

The omnibus directory doesn't include .bundle/bin/rspec anymore, so I use the rspec command from $PATH instead. I also changed it to run the current file by default, instead of asking you to input the file path.

I also moved the tests command to the top of the list, so it runs by default when hitting F5. I think it's more common than debugging dry-run.rb.

@JamieMagee JamieMagee requested a review from a team as a code owner January 12, 2024 17:43
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with vscode, but the changes here look sensible!

@jakecoffman jakecoffman enabled auto-merge (squash) January 16, 2024 16:32
@jakecoffman jakecoffman merged commit 0c70225 into main Jan 16, 2024
49 checks passed
@jakecoffman jakecoffman deleted the jamiemagee/rspec-launch branch January 16, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants