always clone all the ecosystems #8933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
L: go:modules
abdulapopoola
approved these changes
Jan 29, 2024
JamieMagee
approved these changes
Jan 29, 2024
|
I deleted the few remaining integration tests as they rely on some amount of mocking to work, and should be covered by smoke tests and the new silent tests. The github_actions smoke test is failing, but the data is the same just reordered, so I can regenerate it after merging. So I think this is good to go. |
This was referenced Jan 31, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables cloning for all ecosystems. It looks like most of them were cloning already at this point.
There's more code that can be cleaned up if you pull the
job.clone?thread, but this is good for now.