Report Sorbet issue to sentry without raising #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
force-pushed
the
jurre/report-sorbet-runtime-without-failing
branch
3 times, most recently
from
d6fdcaf
to
04fb5db
Compare
jurre
commented
Feb 6, 2024
JamieMagee
reviewed
Feb 6, 2024
JamieMagee
reviewed
Feb 6, 2024
JamieMagee
reviewed
Feb 6, 2024
jurre
force-pushed
the
jurre/report-sorbet-runtime-without-failing
branch
from
04fb5db
to
b7d659f
Compare
JamieMagee
reviewed
Feb 7, 2024
JamieMagee
reviewed
Feb 7, 2024
JamieMagee
approved these changes
Feb 8, 2024
jurre
force-pushed
the
jurre/report-sorbet-runtime-without-failing
branch
from
848b331
to
291624f
Compare
jurre
force-pushed
the
jurre/report-sorbet-runtime-without-failing
branch
3 times, most recently
from
ce10c3a
to
618dda7
Compare
JamieMagee
force-pushed
the
jurre/report-sorbet-runtime-without-failing
branch
from
618dda7
to
92d9bd7
Compare
|
Any blockers with merging this @jurre and @JamieMagee ? |
|
I think this is ready to go |
|
No blockers other than time available in the day |
Previously if Sorbet found runtime typecheck failures, these would result in an exception, halting further job execution. While we should be informed of those failures, there is no reason why this should end up failing the job for our customers. This PR configures Sorbet to report the exceptions to Sentry but continue processing.
Co-authored-by: Jamie Magee <jamagee@microsoft.com>
Co-authored-by: Jamie Magee <jamagee@microsoft.com>
jurre
force-pushed
the
jurre/report-sorbet-runtime-without-failing
branch
from
92d9bd7
to
c00a883
Compare
davidstosik
reviewed
Feb 22, 2024
| @@ -1,4 +1,5 @@ | |||
| <h1 align="center"> | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if Sorbet found runtime typecheck failures, these would result in an exception, halting further job execution.
While we should be informed of those failures, there is no reason why this should end up failing the job for our customers.
This PR configures Sorbet to report the exceptions to Sentry but continue processing.