Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict type Dependabot::MetadataFinders::Base::ChangelogFinder #9029

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Strict type Dependabot::MetadataFinders::Base::ChangelogFinder #9029

merged 1 commit into from
Feb 12, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Feb 11, 2024 •
edited

This has a lot of:

  • T.unsafe because the source platform clients (GitHub, Azure DevOps, etc.) all use method_missing to inject credentials or handle retries. Rewriting them is going to be difficult 馃槚
  • OpenStruct and Sawyer::Resource return types, again because of source platform clients
  • T.untyped response types because of (you guessed it!) source platform clients

@JamieMagee JamieMagee added the sorbet 馃崷 Relates to Sorbet types label Feb 11, 2024
@JamieMagee JamieMagee marked this pull request as ready for review February 12, 2024 15:30
@JamieMagee JamieMagee requested a review from a team as a code owner February 12, 2024 15:30
@abdulapopoola abdulapopoola merged commit edfc38d into main Feb 12, 2024
140 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/strict-type-changelog-finder branch February 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

Assignees
No one assigned
Labels
sorbet 馃崷 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamieMagee @abdulapopoola