Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test more of the security error scenarios #9039

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

jakecoffman
Copy link
Member

Improving test coverage of the error conditions unique to security updates.

@jakecoffman jakecoffman requested a review from a team as a code owner February 12, 2024 14:59
Copy link
Member

@bdragon bdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to add these!

- dependency-name: dependency-a
affected-versions:
- <= 1.2.3
patched-versions: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's material to the test working, so feel free to ignore: I think realistically patched-versions would include 1.2.4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen that field set to a value other than []!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; do you know why that is the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't, would need to dig into that.

@jakecoffman jakecoffman enabled auto-merge (squash) February 12, 2024 19:21
@jakecoffman jakecoffman merged commit d63dd7e into main Feb 12, 2024
53 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/security-tests branch February 12, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants