use boolean for clearer signal of a grouped update #9041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smoke tests should be fixed by this PR: dependabot/smoke-tests#184 |
jurre
reviewed
Feb 13, 2024
Comment on lines
169
to
171
| # We will need to do a pass updating the CLI and smoke tests before this is possible, | ||
| # so let's consider it optional for now. If we get a nil value, let's force it to be | ||
| # an array. |
There was a problem hiding this comment.
I think this comment applies to the @dependency_groups variable, so let's move things around so it stays close?
jurre
approved these changes
Feb 13, 2024
|
Now that we did #9040 I'm inclined to not do this and continue to let the updater code figure out if it's grouped based on the presence of a group that applies in the job definition. The main factor for this before was that the API was sending groups with security updates, so it wasn't possible to decide if the updater was supposed to use it. Now that it is explicit with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8963 I am running into a problem where using
directoryanddirectoriesis not a clear enough signal that this is supposed to be a grouped update, so switching to thegrouped-updateboolean.