Prevent attempt to create empty commit #9061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously #store_change would attempt to create a git commit with no staged changes if there were changes to ignored files. As of this change, the method returns early if there are no changes (to un-ignored files) to commit. Fixes: #9060
honeyankit
approved these changes
Feb 15, 2024
abdulapopoola
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Dependabot::Workspace::Git#store_changewould attempt to create a git commit if there were changes to ignored files, which would causegit committo return a non-zero status and fail the job. As of this change, the method returns early if there are no changes (to un-ignored files) to commit.Fixes: #9060