Update referenced projects during a run of NuGetUpdater. #9097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
joerobich/updateReferencedProjects
branch
from
764cfc1
to
7eacd94
Compare
JoeRobich
commented
Feb 22, 2024
|
|
||
| // update all dependencies, including transitive | ||
| var buildFiles = await MSBuildHelper.LoadBuildFiles(repoRootPath, projectPath); |
There was a problem hiding this comment.
The changes in this file are mostly just grouping logic into methods to make this more readable.
| var projectRootElement = ProjectRootElement.Open(projFilePath); | ||
| projectStack.Push((Path.GetFullPath(Path.GetDirectoryName(projFilePath)!), projectRootElement)); | ||
| } | ||
| catch (InvalidProjectFileException) |
There was a problem hiding this comment.
Needed to guard against invalid projects in this method because we are now looking for project paths before processing the project.
Comment on lines
+114
to
+120
| var projectFilePaths = MSBuildHelper.GetProjectPathsFromProject(projectPath); | ||
| foreach (var projectFullPath in projectFilePaths.Concat([projectPath])) | ||
| { | ||
| // If there is some MSBuild logic that needs to run to fully resolve the path skip the project | ||
| if (File.Exists(projectFullPath)) | ||
| { | ||
| await RunUpdaterAsync(repoRootPath, projectFullPath, dependencyName, previousDependencyVersion, newDependencyVersion, isTransitive); |
There was a problem hiding this comment.
This is the heart of the change. We now collect referenced projects and update them as we do for dirs.proj.
…dabot/dependabot-core into joerobich/updateReferencedProjects
brettfo
approved these changes
Feb 23, 2024
ryanbrandenburg
approved these changes
Feb 23, 2024
|
Hi I'll merge this once CI is passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an assumption being made in the Ruby side of the NuGet updater that runs of the native updater were updating the target project and referenced projects. The ruby side would then mark the referenced projects as processed and not attempt to update them separately. Whereas this assumption was true for dirs.proj files it was not true for .csproj, .vbproj, etc... This PR bring the two different ways of processing into alignment and makes the assumption true for all project files.