add more http redirects #9135
Merged
add more http redirects #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing NuGet updates against a GitHub package feed, I discovered that there were other types of
30Xredirects that weren't being followed.This PR follows information found here about various types of
30Xredirects, specifically,301,302,303,307, and308. The redirects not covered are the ones where there's not a specificLocation:header returned that can be followed, e.g.,300which can specify multiple redirect options, but according to the documentation is rare, and304which means a cached version can be used, but our updater won't have a cached version to use.