Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure T::Set from NuGetClient.get_package_versions #9180

Merged
merged 5 commits into from Mar 4, 2024
Merged

Ensure T::Set from NuGetClient.get_package_versions #9180

merged 5 commits into from Mar 4, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Mar 1, 2024 •
edited

From an example stack trace:

Return value: Expected type T.nilable(T::Set[String]), got type Array with value [...]
Caller: /home/dependabot/nuget/lib/dependabot/nuget/nuget_client.rb:21
Definition: /home/dependabot/nuget/lib/dependabot/nuget/nuget_client.rb:33

@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Mar 1, 2024
@JamieMagee JamieMagee requested a review from a team as a code owner March 1, 2024 16:30
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 1, 2024
@abdulapopoola abdulapopoola merged commit be5bbe2 into main Mar 4, 2024
67 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/nuget-return-set branch March 4, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamieMagee @abdulapopoola @JoeRobich