don't assume the Include
attribute is present on a <ProjectReference>
node
#9238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing project references, we were assuming all of the elements looked like this:
If that
Include
attribute isn't present, then we'll eventually throw with:The fix is to simply skip processing that particular
<ProjectReference>
element if it doesn't have the requisite attribute. Similar behavior is also present elsewhere inproject_file_parser.rb
, so it's a known pattern that we just missed applying here.Of all of the current
undefined method '_' for nil:NilClass
errors in NuGet, this is the largest class.