📏 Standardize Error Keys

[landongrindheim]

We're using a mix of dashes and underscores, which I find confusing. I've introduced some failures trying to get these right, so I'm making all string keys dasherized.

[JamieMagee]

What would you say to making these constants in common/lib/dependabot/errors.rb?

[jeffwidman]

Thinking aloud: It's a little weird that everything else extracted from job.* has a key of job-*... but this doesn't. It's probably nbd but thought I'd mention it...

[abdulapopoola]

along the lines of creating the ERROR_ATTRIBUTES constant; would it be useful to create a method to handle generating the unknown_error_details which accepts and error and job parameters? That would facilitate reuse and standardization

[landongrindheim]

I considered this, but didn't pursue it because Service#capture_exception accepts other arguments for job-dependencies and job-dependency-groups. These are being provided in ErrorHandler#error_details_for. IMO, it'd be preferable to standardize usage, but I think that stretches the task I'm trying to complete a little too far.

[abdulapopoola]

Thanks, please for my learning; from this code, the dependency and the dependency-groups seem to come from the same job value. If so, what are the tradeoffs being considered and the costs involved?

[landongrindheim]

I'm not 100% sure I understand the question, but I'll speak to what I think I understand.

Within Service#capture_exception, we prioritize the values passed in as dependency and dependency_group (ex dependency&.name || job&.dependencies). There's one place where these values are being provided 👇

          service.capture_exception(
            error: error,
            job: job,
            dependency: dependency,
            dependency_group: dependency_group
          )

This method is being delegated to by other methods, which appear at pretty high levels 👇 I count seven places that would need to be updated/refactored to make this a re-usable method that only fetches the information from job. I don't love the current state, but I do see the value that's gained by getting reports about individual dependencies (vs all dependencies for the job).

#handle_job_error	#handle_dependency_error