Type more classes #9275
Merged
Type more classes #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
dev/rybrande/NugetType
branch
from
8181258
to
2354fb3
Compare
JamieMagee
approved these changes
Mar 13, 2024
|
@ryanbrandenburg I added some more types based on yours to get each file to |
JoeRobich
approved these changes
Mar 13, 2024
JamieMagee
force-pushed
the
dev/rybrande/NugetType
branch
from
4497215
to
d25cba0
Compare
Thanks! I just had an awkard amount of time so I figured I'd make it easier for someone else to move things to strict/strong, but I didn't think it'd happen in the same PR lol. |
JamieMagee
force-pushed
the
dev/rybrande/NugetType
branch
from
d25cba0
to
56e58b5
Compare
abdulapopoola
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just sprinkling some Sorbet around the nuget Ruby code where it was easy to determine the parameter and return types.