Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type remainder of NuGet #9337

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

JamieMagee
Copy link
Contributor

No description provided.

@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Mar 20, 2024
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 20, 2024
@JamieMagee JamieMagee marked this pull request as ready for review March 20, 2024 22:42
@JamieMagee JamieMagee requested a review from a team as a code owner March 20, 2024 22:42
@JamieMagee JamieMagee force-pushed the jamiemagee/strict-type-nuget branch 2 times, most recently from 342af9c to a7700bc Compare March 20, 2024 22:44
@JamieMagee JamieMagee changed the title Strict type more of NuGet Strict type remainder of NuGet Mar 20, 2024
@abdulapopoola abdulapopoola merged commit d2b94f6 into main Mar 22, 2024
67 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/strict-type-nuget branch March 22, 2024 17:10
JamieMagee added a commit that referenced this pull request Mar 22, 2024
…tcher`

Fix from #9337

Seen in production stack traces

```
Parameter 'package_version': Expected type String, got type NilClass
Caller: /home/dependabot/nuget/lib/dependabot/nuget/update_checker/dependency_finder.rb:186
Definition: /home/dependabot/nuget/lib/dependabot/nuget/update_checker/nuspec_fetcher.rb:25
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants