only report dependencies whose version numbers can be resolved #9387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-package-version-resolution
branch
2 times, most recently
from
a0c18f0
to
a05daa6
Compare
JamieMagee
reviewed
Mar 29, 2024
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs
Show resolved
Hide resolved
JamieMagee
approved these changes
Mar 29, 2024
JoeRobich
approved these changes
Apr 1, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-package-version-resolution
branch
2 times, most recently
from
e850997
to
c35fef2
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-package-version-resolution
branch
from
c35fef2
to
39bdff2
Compare
jakecoffman
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package version is a property that can't be resolved, don't throw because it fails the entire update process. Instead exclude that dependency.