remove redundant parsing of original files #9424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention that the code I'm removing was added in #8803, and we have a test for that case which is still passing. So this should be good to go! |
honeyankit
approved these changes
Apr 3, 2024
pavera
approved these changes
Apr 3, 2024
jakecoffman
deleted the
jakecoffman/remove-redundant-parsing-of-original-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8963 I made DependencySnapshot aware of multiple directories, so we can remove this TODO now.
This should speed up all grouped updates a small amount because it was re-parsing the files an extra time for each group.
Now we can simply do
dependency_snapshot.dependencieswhich will return what DependencySnapshot parsed at the beginning of the job run.