Avoid passing empty strings as versions, part 2 #9471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdragon
added
T: bug 🐞
jurre
approved these changes
Apr 10, 2024
jurre
reviewed
Apr 10, 2024
If a Dependabot::Dependency is initialized with a version or previous_version that is an empty string, set it to nil.
bdragon
force-pushed
the
bdragon/iss-9430
branch
from
027d9c2
to
0ee3145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue described/addressed in #9461 is still causing runtime exceptions. Instead of dancing around the issue by trying to prevent empty string versions everywhere, this change updates
Dependabot::Dependencyby initializing itsversion/previous_versionto nil if the given value for either resolves to an empty string.Fixes #9430