Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix smoke tests not running #9487

Merged
merged 1 commit into from Apr 12, 2024
Merged

fix smoke tests not running #9487

merged 1 commit into from Apr 12, 2024

Conversation

jakecoffman
Copy link
Member

This branch doesn't exist so the smoke tests weren't running.

@jakecoffman jakecoffman requested a review from a team as a code owner April 12, 2024 14:18
@jakecoffman jakecoffman enabled auto-merge (squash) April 12, 2024 14:18
@jakecoffman jakecoffman merged commit e74e7f4 into main Apr 12, 2024
101 of 102 checks passed
@jakecoffman jakecoffman deleted the jakecoffman-patch-1 branch April 12, 2024 14:39
@Nishnha
Copy link
Member

Nishnha commented Apr 15, 2024 •
edited

Sorry! I thought I had fixed this in #9473 but it seems like after the base changed back to main, 05992c0 was dropped from the PR?

Not sure how that happened though

@jakecoffman jakecoffman mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landongrindheim landongrindheim landongrindheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakecoffman @Nishnha @landongrindheim