Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow packages.config update when project file doesn't list assembly version #9534

Merged

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Apr 18, 2024

When updating in a packages.config scenario, the .csproj doesn't have to list the assembly version. This modifies the check to allow either Include="Some.Dependency" or Include="Some.Dependency, Version=1.2.3.4, ....".

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Apr 18, 2024
@brettfo brettfo marked this pull request as ready for review April 18, 2024 23:13
@brettfo brettfo requested a review from a team as a code owner April 18, 2024 23:13
@brettfo brettfo force-pushed the dev/brettfo/packages-config-without-assembly-version branch from d93a835 to 1b2f69d Compare April 18, 2024 23:15
@abdulapopoola abdulapopoola merged commit 823417b into main Apr 18, 2024
69 checks passed
@abdulapopoola abdulapopoola deleted the dev/brettfo/packages-config-without-assembly-version branch April 18, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants