cache results of the discovery tool #9566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/cache-nuget-discovery
branch
from
2e9b4a2
to
a269f18
Compare
JoeRobich
approved these changes
Apr 22, 2024
brettfo
force-pushed
the
dev/brettfo/cache-nuget-discovery
branch
4 times, most recently
from
aca84f7
to
9170408
Compare
brettfo
force-pushed
the
dev/brettfo/cache-nuget-discovery
branch
from
9170408
to
6e37442
Compare
Open
1 task
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added
discovercommand is only dependent on theworkspace_pathvalue, so use that as a cache key.Previously, it was possible for the
discovercommand to be run multiple times and in some large repos, that could lead to a timeout. Also moved the reporting of the results of thediscovercommand to just after it actually runs so it's not repeated in the log.