-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot core issue npe composer fileparser #9643
Merged
GarryHurleyJr
merged 25 commits into
main
from
dependabot-core-issue-npe-composer-fileparser
May 3, 2024
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3df7ef0
Issue 5919 - added check for nil in file parser. fileparser.spec is …
GarryHurleyJr 0e246cd
issue #5919 - cleaning up test code
GarryHurleyJr 2cc20e4
issue #5919 - cleaning up test code error
GarryHurleyJr 85f669a
issue #5919 - cleaning up test code error
GarryHurleyJr 95bbce0
Issue 5919 - added check for nil in file parser. fileparser.spec is …
GarryHurleyJr 81a0a45
issue #5919 - cleaning up test code
GarryHurleyJr c344e7d
issue #5919 - cleaning up test code error
GarryHurleyJr e0894f2
issue #5919 - cleaning up test code error
GarryHurleyJr 01ffa13
Merge branch 'dependabot-core-issue-npe-composer-fileparser' of https…
GarryHurleyJr f6de867
issue #5919 - cleaning up Lint issues
GarryHurleyJr 269af04
Issue #9634 - cleaned up code to remove overthought solution.
GarryHurleyJr 34667ad
Issue #9643 - cleaned up lint issues in code.
GarryHurleyJr 2ff1e72
Issue #9643 - cleaned up lint issues in code.
GarryHurleyJr 39f2e62
Issue #9643 - cleaned up lint issues in code.
GarryHurleyJr 006fa52
Issue #9643 - cleaned up lint issues in code.
GarryHurleyJr 4552769
Merge branch 'main' into dependabot-core-issue-npe-composer-fileparser
GarryHurleyJr 3af7bb0
Merge branch 'main' into dependabot-core-issue-npe-composer-fileparser
GarryHurleyJr 9a82d69
Issue #9643 created test and changed code to make sure NPE no longer …
GarryHurleyJr 707e101
Issue #9643 resolved lint issues
GarryHurleyJr 9c02dc8
Merge branch 'main' into dependabot-core-issue-npe-composer-fileparser
GarryHurleyJr 13f7f15
Issue #5919 - code review feedback changes
GarryHurleyJr 2febbd3
Merge branch 'dependabot-core-issue-npe-composer-fileparser' of https…
GarryHurleyJr 80c2a7a
Merge branch 'main' into dependabot-core-issue-npe-composer-fileparser
GarryHurleyJr e4376a2
Merge branch 'main' into dependabot-core-issue-npe-composer-fileparser
GarryHurleyJr d322cd2
Merge branch 'main' into dependabot-core-issue-npe-composer-fileparser
GarryHurleyJr File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
composer/spec/fixtures/projects/null_dependencies_with_lockfile/composer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"name": "joshuaestes/server-tools", | ||
"description": "Collection of command line tools to help with server management and maintenance", | ||
"keywords": [], | ||
"homepage": "https://github.com/JoshuaEstes/ServerTools", | ||
"license": "MIT", | ||
"authors": [ | ||
{ | ||
"name": "Joshua Estes", | ||
"homepage": "http://joshuaestes.me" | ||
}, | ||
{ | ||
"name": "Contributors", | ||
"homepage": "https://github.com/JoshuaEstes/ServerTools/graphs/contributors" | ||
} | ||
], | ||
"minimum-stability": "dev", | ||
"require": { | ||
"php": ">=5.3.2", | ||
"symfony/console": ">=2.1,<=2.3@dev", | ||
"symfony/process": ">=2.1,<=2.3@dev", | ||
"symfony/yaml": ">=2.1,<=2.3@dev", | ||
"symfony/finder": ">=2.1,<=2.3@dev", | ||
"symfony/filesystem": ">=2.1,<=2.3@dev" | ||
}, | ||
"replace": { | ||
"JoshuaEstes/ServerTools": "self.version" | ||
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "*", | ||
"mikey179/vfsStream": "*" | ||
}, | ||
"autoload": { | ||
"psr-0": { "": "src/" } | ||
}, | ||
"extra": { | ||
"branch-alias": { | ||
"dev-master": "2.0-dev" | ||
} | ||
} | ||
} |
249 changes: 249 additions & 0 deletions
249
composer/spec/fixtures/projects/null_dependencies_with_lockfile/composer.lock
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a link to the bug/issue this is addressing somewhere? I understand what this test is doing but I'm not sure what behavior it's trying to fix/verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bryan,
The issue is #5919
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!