Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6017: Address RSpec/ContextWording Rubocop violations. #9727

Merged
merged 16 commits into from
May 16, 2024

Conversation

thavaahariharangit
Copy link
Collaborator

Updating context messages when it's not starting with when, without or without

@thavaahariharangit thavaahariharangit requested review from a team as code owners May 14, 2024 12:20
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: devcontainers labels May 14, 2024
@thavaahariharangit thavaahariharangit merged commit 0a333d2 into main May 16, 2024
121 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/#6017 branch May 16, 2024 14:59
@@ -47,7 +47,7 @@
])
end

context "specified as the default source" do
context "with specified as the default source" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thavaahariharangit same thing on a lot of these as well, this should really read

when specified as the default source

jurre added a commit that referenced this pull request May 17, 2024
jurre added a commit that referenced this pull request May 17, 2024
…ording

Revert "#6017: Address RSpec/ContextWording Rubocop violations. (#9727)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dart:pub Dart packages via pub L: devcontainers L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: terraform Terraform packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants