Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harry/text improvement, context wording, for ecosystem bundler, review comments of #9758 addressed here. #9782

Merged
merged 11 commits into from
May 24, 2024
2 changes: 1 addition & 1 deletion .codespellrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ skip = .git,*.pdf,*.svg,gems,index,fixtures,CHANGELOG_ARCHIVE_*,yarn.lock
ignore-regex = \bsha512-[^"]*|ENV\["ROUGE"\]|\b(com\.google\.errorprone)\b|\bto(_not)? include .*versio"|https://\S*
# some modules, parts of regexes, and variable names to ignore, some
# misspellings in fixtures/external responses we do not own
ignore-words-list = caf,bu,nwo,nd,kernal,crate,unparseable,couldn,defintions
ignore-words-list = caf,bu,nwo,nd,kernal,crate,unparseable,couldn,defintions,hashin
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

it { is_expected.to eq([Pathname.new("plugins/example")]) }

context "when the path must be eval-ed" do
context "when gemspec path must be evaluated" do
let(:gemfile) { bundler_project_dependency_file("path_source_eval", filename: "Gemfile") }

it "raises a helpful error" do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,20 @@
end

# rubocop:disable Lint/InterpolationCheck
context "when that needs to be evaled" do
context "when the file body needs to be evaluated" do
let(:file_body) do
'require_relative "./my_file_#{raise %(hell)}"'
end

it { is_expected.to eq([]) }
end

context "when it can't be" do
let(:file_body) do
'require_relative "./my_file_#{unknown_var}"'
end

it { is_expected.to eq([]) }
context "when the file body can't be evaluated" do
let(:file_body) do
'require_relative "./my_file_#{unknown_var}"'
end

it { is_expected.to eq([]) }
end
# rubocop:enable Lint/InterpolationCheck

Expand Down
8 changes: 4 additions & 4 deletions bundler/spec/dependabot/bundler/file_fetcher_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
.to match_array(%w(Gemfile Gemfile.lock .ruby-version))
end

context "when that can't be found" do
context "when the files can't be found" do
before do
stub_request(:get, url + "?ref=sha")
.with(headers: { "Authorization" => "token token" })
Expand All @@ -94,7 +94,7 @@
end
end

context "when that returns a file" do
context "when returning a file" do
before do
stub_request(:get, url + "?ref=sha")
.with(headers: { "Authorization" => "token token" })
Expand Down Expand Up @@ -234,7 +234,7 @@
)
end

context "when that has a fetchable path" do
context "when there is a fetchable path" do
before do
stub_request(:get, imported_file_url + "?ref=sha")
.with(headers: { "Authorization" => "token token" })
Expand Down Expand Up @@ -280,7 +280,7 @@
)
end

context "when that has a fetchable path" do
context "when there is a fetchable path" do
before do
stub_request(:get, url + "plugins/bump-core?ref=sha")
.with(headers: { "Authorization" => "token token" })
Expand Down