Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve NuGet discovery by expanding *.proj and *.sln files #9785

Merged
merged 6 commits into from
May 24, 2024

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented May 21, 2024

This also removes a recursive search that wasn't correct; the only entry points allowed from any given directory are the following:

  • *.sln // n.b., this will be expanded to regular project files
  • *.proj // n.b., this will be expanded to regular project files
  • *.(cs|vb|fs)proj // regular project files

This fixes some internal issues where a .sln file might be in a different directory than the projects, e.g., dependabot is started in the /solutions directory and the following files exist: /solutions/the-solution.sln and /src/project.csproj. Previously, dependabot wouldn't have been able to navigate from the /solutions directory over to /src but now as long as the project listing in the .sln is correct, then we'll pull in the correct projects.

The same applies to *.proj files as well as *.(cs|vb|fs)proj files that might have had a <ProjectReference> element to another directory.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label May 21, 2024
@brettfo brettfo force-pushed the dev/brettfo/nuget-discovery-expansion branch from 3f56ac9 to cfc1a7f Compare May 21, 2024 17:05
@samtrion
Copy link

@brettfo It would certainly make sense to also consider the open feature requests during this refactoring.

#9711
#9745

@brettfo
Copy link
Contributor Author

brettfo commented May 22, 2024

@samtrion There's more than just this PR to enable anything that's not .csproj/.vbproj/.fsproj so I'll leave that for the future just to keep this PR focused.

@brettfo brettfo force-pushed the dev/brettfo/nuget-discovery-expansion branch 4 times, most recently from 6e7ecf5 to d152368 Compare May 22, 2024 19:31
@brettfo brettfo marked this pull request as ready for review May 22, 2024 19:59
@brettfo brettfo requested a review from a team as a code owner May 22, 2024 19:59
@sachin-sandhu sachin-sandhu force-pushed the dev/brettfo/nuget-discovery-expansion branch from d152368 to 08946ee Compare May 24, 2024 16:24
@sachin-sandhu sachin-sandhu merged commit 05f314a into main May 24, 2024
67 checks passed
@sachin-sandhu sachin-sandhu deleted the dev/brettfo/nuget-discovery-expansion branch May 24, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants