-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable RSpec/DescribedClass #9790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes as I see this has been approved, but there have since been comments which will cause tests to not be run. We should address these before merging.
before do | ||
stub_request(:get, hex_url).to_return(status: 200, body: hex_response) | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 For next time: these changes seem to be unrelated to the focus of this PR. It'd be great to keep unrelated changes separate 🙂 That said, the functionality remains, so I think we're okay to go.
https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecdescribedclass