Fix calloc-transposed-args with prism
#9810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
jamiemagee/prism-calloc
branch
from
250ac45
to
06c53e3
Compare
robaiken
approved these changes
May 23, 2024
jurre
approved these changes
May 23, 2024
JamieMagee
force-pushed
the
jamiemagee/prism-calloc
branch
3 times, most recently
from
d225009
to
a05e036
Compare
GCC 14 was release on 7th May[^1]. It introduced a new warning `-Wno-calloc-transposed-args`[^2] designd to raise a warning when the arguments to `calloc` were given in the wrong order.
Unfortunately, `prism` version `0.24.0` made this mistake. Attempting to `bundle install` Dependabot gives the error:
<details>
<summary>Error details</summary>
```
src/diagnostic.c: In function ‘pm_diagnostic_list_append’:
src/diagnostic.c:328:69: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
328 | pm_diagnostic_t *diagnostic = (pm_diagnostic_t *) calloc(sizeof(pm_diagnostic_t), 1);
| ^~~~~~~~~~~~~~~
src/diagnostic.c:328:69: note: earlier argument should specify number of elements, later size of each element
src/diagnostic.c: In function ‘pm_diagnostic_list_append_format’:
src/diagnostic.c:359:69: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
359 | pm_diagnostic_t *diagnostic = (pm_diagnostic_t *) calloc(sizeof(pm_diagnostic_t), 1);
| ^~~~~~~~~~~~~~~
src/diagnostic.c:359:69: note: earlier argument should specify number of elements, later size of each element
cc1: all warnings being treated as errors
```
</details>
The issue was logged upstream in ruby/prism#2645, fixed in ruby/prism#2648, and released in https://github.com/ruby/prism/releases/tag/v0.25.0.
This change upgrades `prism`, by way of upgrading `rbi`, and resolves the compile error.
[^1]: https://gcc.gnu.org/gcc-14/
[^2]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-calloc-transposed-args
sachin-sandhu
force-pushed
the
jamiemagee/prism-calloc
branch
from
a05e036
to
273b43d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 14 was release on 7th May1. It introduced a new warning
-Wcalloc-transposed-args2 designd to raise a warning when the arguments tocallocwere given in the wrong order.Unfortunately,
prismversion0.24.0made this mistake. Attempting tobundle installDependabot gives the error:The issue was logged upstream in ruby/prism#2645, fixed in ruby/prism#2648, and released in https://github.com/ruby/prism/releases/tag/v0.25.0.
This change upgrades
prism, by way of upgradingrbi, and resolves the compile error.Footnotes
https://gcc.gnu.org/gcc-14/ ↩
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-calloc-transposed-args ↩