Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RSpec Example cops #9811

Merged
merged 10 commits into from
Jun 5, 2024
Merged

Enable RSpec Example cops #9811

merged 10 commits into from
Jun 5, 2024

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken requested review from a team as code owners May 23, 2024 09:29
@robaiken robaiken self-assigned this May 23, 2024
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: javascript L: python L: swift Swift packages labels May 23, 2024
jurre
jurre reviewed May 23, 2024
View reviewed changes
anyintance Outdated Show resolved Hide resolved
@robaiken robaiken linked an issue May 23, 2024 that may be closed by this pull request
Enable New RuboCop Cops #9573
Closed
abdulapopoola
abdulapopoola reviewed May 31, 2024
View reviewed changes
updater/spec/dependabot/job_spec.rb
@@ -278,7 +278,7 @@
]
end

it "should be allowed" do
it "is allowed" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is allowed? :)

GarryHurleyJr
GarryHurleyJr approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge from main

@GarryHurleyJr GarryHurleyJr merged commit 043c487 into main Jun 5, 2024
121 checks passed
@GarryHurleyJr GarryHurleyJr deleted the robaiken/enable-RSpec-Examples branch June 5, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre jurre left review comments

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

@GarryHurleyJr GarryHurleyJr GarryHurleyJr approved these changes

Assignees

@robaiken robaiken

Labels
L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: swift Swift packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable New RuboCop Cops
5 participants
@robaiken @abdulapopoola @jurre @JamieMagee @GarryHurleyJr