fix nuget ignored package version handling #9824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
May 23, 2024
| @@ -226,7 +226,7 @@ | |||
| end | |||
|
|
|||
| context "when a version range is specified using Ruby syntax" do | |||
| let(:ignored_versions) { [">= 2.a, < 3.0.0"] } | |||
There was a problem hiding this comment.
This test was incorrect because it originally said to exclude anything greater than or equal to 2.a and less than 3, which is an empty set, and given that this test was really only checking the Ruby-specific syntax of 2.a I simplified it.
brettfo
commented
May 23, 2024
| @@ -671,7 +677,7 @@ def create_nupkg(nuspec_name, nuspec_content) | |||
| its([:version]) { is_expected.to eq(version_class.new("2.0.0")) } | |||
|
|
|||
| context "when the user is ignoring the lowest version" do | |||
| let(:ignored_versions) { [">= 2.a, <= 2.0.0"] } | |||
There was a problem hiding this comment.
This test was originally incorrect for the same reason as the one above so it has been simplified.
brettfo
force-pushed
the
dev/brettfo/nuget-ignored-versions
branch
from
3bb609b
to
3a16d12
Compare
sebasgomez238
approved these changes
May 23, 2024
JamieMagee
force-pushed
the
dev/brettfo/nuget-ignored-versions
branch
from
3a16d12
to
96eee27
Compare
sachin-sandhu
force-pushed
the
dev/brettfo/nuget-ignored-versions
branch
from
96eee27
to
cb8dcdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current handling of
ignored_versionsin ajob.ymlfile is incorrect. Consider an example from the unit tests; ajob.ymlcould list that for a certain package,ignored_versionsshould be< 1.1.1, > 1.1.1which should be read as "ignore anything below 1.1.1 and ignore anything above 1.1.1" which boils down to "only accept version 1.1.1". The previous implementation did a slightly different thing of "negate (version is less than 1.1.1 AND version is greater than 1.1.1)" which is impossible; this was a wrong application of our good friend De Morgan.The proper fix here is to turn that check into "negate (version is less than 1.1.1 OR version is greater than 1.1.1)". Thankfully the Maven updater does the correct thing so I could almost directly copy what was done there.
Some additional changes had to be made, namely ensuring that the
ignored_versionsproperty was passed around everywhere and fixing some unit tests that weren't correct.