Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raj-meka/Composer_ignore_condition_issue_fix_where_Composer_Dependabot_not_respecting_ignore_minor/patch_updates #9848

Closed

Conversation

raj-meka
Copy link
Contributor

…_resolve and updateChecker.

@raj-meka raj-meka requested a review from a team as a code owner May 29, 2024 02:19
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label May 29, 2024
@raj-meka
Copy link
Contributor Author

raj-meka commented May 29, 2024

Problem statement: Dependabot does not disregard minor or patch updates in accordance with the job's ignore condition.

To have the dependabot ignore the updates, run a task at composer with the ignore condition set to ignore smver-minor and smever-patch. However, this will result in the creation of a PR.

I can now see that Dependabot is receiving the ignore condition when the job starts as a result of my issue investigation. Therefore, the updater is processing them incorrectly.

I'm giving the PHP native helper the "latest allowable version" as a workaround for the aforementioned issue.
When we initialize the version_resolver class, @latest_allowable_version is set.

I have assigned the argument "latest allowable version" to the PHP class.

I have passed both the dependent and the most recent version permitted in the PHP class, rather than just the dependency.

Thus, I am passing Laravel/Framework instead of Laravel/Farmework:11.8.0

Upgrading to version 11 causes a problem with other requirements like symfony because of the configuration of the client's composer file. The following factors make this failure expected.

  1. Symfony needs to be updated for Laravel 11.
  2. Dependabot is updating Laravel exclusively—not Symphony.
  3. Upgrading Laravel to version 11 is more difficult because the client has pinned their version of Symphony to v6 in their composer file.

I am going to modified the test cases at updateChecker with latest_resolvable_version according to fix.

@jurre

@thavaahariharangit
Copy link
Contributor

covered in #9967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants