Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TICtxtWrd-nuget: Test Improvement, Context Wording, for the ecosystem nuget #9883

Merged
merged 8 commits into from
Jun 4, 2024
Merged

TICtxtWrd-nuget: Test Improvement, Context Wording, for the ecosystem nuget #9883

merged 8 commits into from
Jun 4, 2024

Conversation

thavaahariharangit
Copy link
Contributor

What are you trying to accomplish?

Test Improvement, Context Wording, for the ecosystem nuget

Anything you want to highlight for special attention from reviewers?

Please ensure context wording sensible and meaningful

How will you know you've accomplished your goal?

Ran Linter in dev environment

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested review from a team as code owners June 3, 2024 01:06
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Jun 3, 2024
abdulapopoola
abdulapopoola approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@abdulapopoola abdulapopoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments

“Thavachelvam and others added 5 commits June 3, 2024 10:21
@thavaahariharangit
TICtxtWrd-nuget: Test Improvement, Context Wording, for the ecosystem…
833d81a 
… nuget.
@thavaahariharangit @abdulapopoola
Update nuget/spec/dependabot/nuget/file_fetcher_spec.rb
0593dce 
Co-authored-by: AbdulFattaah Popoola <abdulapopoola@github.com>
@thavaahariharangit @abdulapopoola
Update nuget/spec/dependabot/nuget/update_checker/repository_finder_s…
6c86761 
…pec.rb

Co-authored-by: AbdulFattaah Popoola <abdulapopoola@github.com>
@thavaahariharangit @abdulapopoola
Update nuget/spec/dependabot/nuget/update_checker/repository_finder_s…
052fe0b 
…pec.rb

Co-authored-by: AbdulFattaah Popoola <abdulapopoola@github.com>
@thavaahariharangit
TICtxtWrd-ngt: Updating review comments.
1c4f404
@thavaahariharangit thavaahariharangit mentioned this pull request Jun 3, 2024
Closed
@thavaahariharangit thavaahariharangit merged commit d81f971 into main Jun 4, 2024
67 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/TICtxtWrd-ngt branch June 4, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thavaahariharangit @abdulapopoola @JamieMagee