Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Sorbet error #9973

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Address Sorbet error #9973

merged 8 commits into from
Jun 24, 2024

Conversation

abdulapopoola
Copy link
Member

@abdulapopoola abdulapopoola commented Jun 11, 2024

What are you trying to accomplish?

Trying to address this new class of Sorbet errors:

Dependabot::Sorbet::Runtime::InformationalError: Return value: Expected type Dependabot::Nuget::Version, got type NilClass
Caller: /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:295
Definition: /home/dependabot/nuget/lib/dependabot/nuget/update_checker.rb:41 (Dependabot::Nuget::UpdateChecker#lowest_security_fix_version)
  dependabot-updater/vendor/ruby/3.3.0/gems/sorbet-runtime-0.5.11415/lib/types/configuration.rb:301:in `call_validation_error_handler'
  dependabot-updater/vendor/ruby/3.3.0/gems/sorbet-runtime-0.5.11415/lib/types/private/methods/call_validation.rb:310:in `report_error'
  dependabot-updater/vendor/ruby/3.3.0/gems/sorbet-runtime-0.5.11415/lib/types/private/methods/call_validation_2_7.rb:63:in `block in create_validator_method_fast0'
  dependabot-updater/lib/dependabot/updater/group_update_creation.rb:295:in `all_versions_ignored?'
  dependabot-updater/vendor/ruby/3.3.0/gems/sorbet-runtime-0.5.11415/lib/types/private/methods/call_validation_2_7.rb:1029:in `bind_call'
...
(44 additional frame(s) were not displayed)

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

The Sorbet error goes away in Sentry.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@abdulapopoola abdulapopoola requested a review from a team as a code owner June 12, 2024 14:56
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Jun 12, 2024
@kbukum1 kbukum1 self-assigned this Jun 24, 2024
@kbukum1 kbukum1 added the Ecosystems Used by the maintainer team for internal-facing project tracking label Jun 24, 2024
@kbukum1 kbukum1 merged commit 585f72e into main Jun 24, 2024
67 checks passed
@kbukum1 kbukum1 deleted the abdulapopoola-patch-5 branch June 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ecosystems Used by the maintainer team for internal-facing project tracking L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants