Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #directory to Dependabot::Dependency #9982

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

landongrindheim
Copy link
Member

@landongrindheim landongrindheim commented Jun 12, 2024

What are you trying to accomplish?

This is a concept which has been deemed to be missing. The effect of this is that when a pull request exists for a group, without there being knowledge of a directory, individual pull requests are then created. By adding #directory to Dependabot::Dependency, we'll be able to prevent this.

We'll need to start setting #directory in future changes. By leaving it in its current state, it will be available to the updater (for said future changes), and to consumers of the library.

Anything you want to highlight for special attention from reviewers?

While this change adds an attr_accessor, #directory is not being written or read anywhere yet.

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

This is a concept which has been deemed to be missing. The effect of
this is that when a pull request exists for a group, without there being
knowledge of a directory, individual pull requests are then created. By
adding `#directory` to Dependabot::Dependency, we'll be able to prevent
this.
@landongrindheim landongrindheim marked this pull request as ready for review June 12, 2024 20:30
@landongrindheim landongrindheim requested a review from a team as a code owner June 12, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants