Skip to content

Commit

Permalink
Stop using deprecated set-output (#370)
Browse files Browse the repository at this point in the history
The initial impetus for this change was:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

However, it turns out the entire step is unnecesary since
`actions/setup-node` supports directly reading the `.nvmrc` file.
  • Loading branch information
jeffwidman committed May 18, 2023
1 parent 042f8db commit c40140b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 15 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/check-dist.yml
Expand Up @@ -16,14 +16,10 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Read .nvmrc
id: nvm
run: echo ::set-output name=NVMRC::$(cat .nvmrc)

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: ${{ steps.nvm.outputs.NVMRC }}
node-version-file: .nvmrc

- name: Install NPM dependencies
run: npm ci
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Expand Up @@ -17,14 +17,10 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Read .nvmrc
id: nvm
run: echo ::set-output name=NVMRC::$(cat .nvmrc)

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: ${{ steps.nvm.outputs.NVMRC }}
node-version-file: .nvmrc

- name: Install npm dependencies
run: npm ci
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/dependabot-build.yml
Expand Up @@ -37,14 +37,10 @@ jobs:
ref: ${{ github.event.pull_request.head.ref }}
token: ${{ secrets.DEPENDABOT_AUTOMATION_PAT }}

- name: Read .nvmrc
id: nvm
run: echo ::set-output name=NVMRC::$(cat .nvmrc)

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: ${{ steps.nvm.outputs.NVMRC }}
node-version-file: .nvmrc

- name: Install NPM dependencies
run: npm ci
Expand Down

0 comments on commit c40140b

Please sign in to comment.