Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect dynamic imports #14

Merged
merged 1 commit into from Feb 4, 2019
Merged

Detect dynamic imports #14

merged 1 commit into from Feb 4, 2019

Conversation

WIStudent
Copy link
Contributor

While looking into this issue in precinct I figured out that it is node-ast-module-types that does not detect a script as an es6 module if it contains a dynamic import but no exports or other imports. I extended the isES6Import function to return true when it encounters a dynamic import. The definition for dynamic imports in ESTree can be found here https://github.com/estree/estree/blob/master/experimental/import-expression.md

@mrjoelkemp
Copy link
Collaborator

Thanks a ton for contributing @WIStudent. I just released this in a new minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants