Show correct error message when failing to resolve #29

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@pahen
Collaborator
pahen commented Jan 4, 2017

Depends on #28

@mrjoelkemp

LGTM

+ return '';
+ }
+
+ try {
@mrjoelkemp
mrjoelkemp Jan 4, 2017 Member

Non-blocker: we technically don't need all of this code in the try block. Only two statements might throw:

webpackResolve.create.sync(resolveConfig); and resolver(lookupPath, partial)

@mrjoelkemp mrjoelkemp closed this in d8a5cb2 Jan 4, 2017
@mrjoelkemp
Member

Rebased this after merging the other PR and pushed the rebased version to master. Great work with the webpack fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment