Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 10.13 and upgrade most dependencies #94

Merged
merged 6 commits into from
Nov 30, 2020
Merged

Require Node.js 10.13 and upgrade most dependencies #94

merged 6 commits into from
Nov 30, 2020

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Nov 29, 2020

Node.js 10 is a necessary prequisite to upgrade enhanced-resolve and (hopefully) node-module-lookup-amd after dependents/node-module-lookup-amd#29 is merged.

@realityking
Copy link
Contributor Author

I included the upgrade for enhanced-resolve. It still might make sense to hold off on pushing a new release until dependents/node-module-lookup-amd#29 is merged & released.

@mrjoelkemp
Copy link
Collaborator

Thanks for this @realityking. What does the latest enhanced-resolve bring us that's worth the upgrade? I'm not opposed to the breaking change, just curious what's the gain.

@realityking
Copy link
Contributor Author

@mrjoelkemp Besides less dependencies and deduplication with web pack 5 (which to be honest, is what I'm after) the most significant improvement is that exports is correctly read from package.json files. More details in the changelog: https://github.com/webpack/enhanced-resolve/releases/tag/v5.0.0

@mrjoelkemp
Copy link
Collaborator

Thanks for the details @realityking. I merged your PR and did a major version bump to https://github.com/dependents/node-module-lookup-amd/. Let me know when all of the changes you want are in this PR and it's ready to be merged.

@realityking
Copy link
Contributor Author

@mrjoelkemp module-lookup-amd is updated & PR is good to go. :)

@mrjoelkemp
Copy link
Collaborator

Thanks @realityking. Appreciate the help here. Just released a new major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants