Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node.js 10 + simplify dependencies #29

Merged
merged 5 commits into from
Nov 29, 2020
Merged

Require Node.js 10 + simplify dependencies #29

merged 5 commits into from
Nov 29, 2020

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Nov 28, 2020 •
edited

This PR remove 4 dependencies from module-lookup-amd. 3 by upgrading require-js-config-file and another by pulling in a much simpler version of fileExists into the module.

The minimum Node version is set to 10.13 as that is the version of the first Node 10 LTS. require-js-config-file requires this version as it uses a feature introduced in 10.12.

@realityking realityking mentioned this pull request Nov 29, 2020
Merged
@realityking
Copy link
Contributor Author

It turns out rewire's functionality is not used in the test suite. I added a commit removing it to fix #28. That commit also adds Node.js 14 to the test matrix.

@mrjoelkemp mrjoelkemp merged commit 47c4dc6 into dependents:master Nov 29, 2020
@mrjoelkemp
Copy link
Collaborator

Thanks @realityking!

@realityking realityking deleted the node-10 branch November 29, 2020 16:36
@realityking realityking mentioned this pull request Jan 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realityking @mrjoelkemp