Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Removed useless prefixes of the links in the project #183

Merged
merged 5 commits into from
Jun 25, 2019
Merged

Removed useless prefixes of the links in the project #183

merged 5 commits into from
Jun 25, 2019

Conversation

Kastakin
Copy link
Contributor

@Kastakin Kastakin commented Jun 24, 2019

As requested in the following issue #182

@Kastakin Kastakin mentioned this pull request Jun 24, 2019
@orsinium
Copy link
Member

Wow, that was fast. Thank you :)

You've dropped these prefixes from external links (pytest, setuptools). Could you put it back, please? And check CI results, they are red by some reason.

@Kastakin
Copy link
Contributor Author

I'm gonna bring the ones you pointed out back!
The CI results show that some links are "bare-urls", I don't really know why they doesn't pass the test since I didn't change the formatting of the links but just the URL itself

@Kastakin
Copy link
Contributor Author

My MDLinter had different parameters so I had to do a double commit to have the pull request to be checked by CI.

I fixed some broken links I messed up here and there while removing the prefixes, it should be ok now I think! :)
Just let me know if you see something out of place!

@orsinium orsinium merged commit 87bbf68 into dephell:master Jun 25, 2019
@orsinium
Copy link
Member

Perfect! Thank you for your help and congratulations with your first pull request :)

If you will be willing to dive a little into sphinx, we have a simple task in #180. Any contributions are always welcome here. And feel free to ask any questions and open issues for bugs and ideas.

@Kastakin Kastakin deleted the readme_links branch June 25, 2019 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants