Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal-client): add req.resume() #785

Merged
merged 1 commit into from
Nov 23, 2016
Merged

fix(internal-client): add req.resume() #785

merged 1 commit into from
Nov 23, 2016

Conversation

andreialecu
Copy link
Contributor

@andreialecu andreialecu commented Nov 22, 2016 •
edited
Loading

Description

The doh package calls req.resume() when an error occurs, but when using an internal dpd client call, the req is mocked. It previously didn't have a .resume() method, resulting in hard crashes under certain conditions when an error occured in a subsequent client script.

See ritch/doh#1

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@andreialecu
fix(internal-client): add req.resume()
25b2d0b 
The doh package calls req.resume() when an error occurs, but when using an internal dpd client call, the req is mocked. It previously didn't have a .resume() method, resulting in hard crashes under certain conditions when an error occured in a subsequent client script.
@andreialecu andreialecu merged commit 5e2c781 into deployd:master Nov 23, 2016
NicolasRitouet pushed a commit that referenced this pull request Jul 27, 2017
@andreialecu @NicolasRitouet
fix(internal-client): add req.resume() (#785)
c92d9bf 
The doh package calls req.resume() when an error occurs, but when using an internal dpd client call, the req is mocked. It previously didn't have a .resume() method, resulting in hard crashes under certain conditions when an error occured in a subsequent client script.
@andreialecu andreialecu deleted the fix-reqresume branch November 3, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasRitouet NicolasRitouet NicolasRitouet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreialecu @NicolasRitouet