Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long http user name is not detected correctly #1579

Closed
Jontsa opened this issue Apr 4, 2018 · 0 comments
Closed

Long http user name is not detected correctly #1579

Jontsa opened this issue Apr 4, 2018 · 0 comments
Labels
Milestone

Comments

@Jontsa
Copy link

Jontsa commented Apr 4, 2018

Q A
Issue Type Bug
Deployer Version 6.1.0
Local Machine OS Ubuntu 17.10
Remote Machine OS Centos

Description

When the http user username is longer than 7 characters, the ps axo user,comm command seen here will cut the username and $httpUser gets an incorrect value.

In my case the http user on the remote machine is "deployment" so the above command output is:

$ ps axo user,comm | grep -E '[a]pache|[h]ttpd|[_]www|[w]ww-data|[n]ginx' | grep -v root | head -1 | cut -d ' ' -f1
deploym+

To fix this issue, either the width of user-column needs to be increased using user:width or move user to the last column of ps axo output. Similar issue can be found in Askubuntu. For example:

$ ps axo user:20,comm | grep -E '[a]pache|[h]ttpd|[_]www|[w]ww-data|[n]ginx' | grep -v root | head -1 | cut -d ' ' -f1
deployment

Steps to reproduce

Content of deploy.php

Output log

@antonmedv antonmedv added this to the 6.1 milestone Apr 4, 2018
ryandev421 added a commit to ryandev421/deployer that referenced this issue Apr 5, 2018
antonmedv pushed a commit that referenced this issue May 3, 2018
* moving the name column to the last position to show full name

- bug fix: #1579

* add changelog

* update changelog.md

* update CHANGELOG.md

* modify command to find http user

* modify command to find http user

* modify wrong ticket url
antonmedv pushed a commit that referenced this issue Aug 27, 2018
* moving the name column to the last position to show full name

- bug fix: #1579

* add changelog

* update changelog.md

* update CHANGELOG.md

* modify command to find http user

* modify command to find http user

* modify wrong ticket url
antonmedv pushed a commit that referenced this issue Sep 5, 2018
* modify wrong ticket url (#1605)

* moving the name column to the last position to show full name

- bug fix: #1579

* add changelog

* update changelog.md

* update CHANGELOG.md

* modify command to find http user

* modify command to find http user

* modify wrong ticket url

* Remove magento:enable from Magento 2 recipe (#1606)

* Remove magento:enable from Magento 2 recipe

Magento's module states are stored in app/etc/config.php. This task
ignored that and blindly enabled all installed modules.

* Mention the removal of magento:enable in the changelog

* Extend deploy:cleanup with tty allocation when using sudo. (#1607)

* Added option cleanup_tty to allow allocation when using sudo

* Added comment for new option cleanup_tty to CHANGELOG

* Allow to set template path in Drupal 7 Settings recipe (#1613)

* Change drupal:settings task to drupal:configure

* Drupal 7 recipe - Set template file path

* Changelog

* Fixed once() tasks that where being run multiple times with ParallelE… (#1624)

* Fixed once() tasks that where being run multiple times with ParallelExecutor

* CHANGELOG: reorder issue

* Add test case for parallel deploy on ->once() task

* Added cleanup_use_sudo option to all commands in deploy:cleanup (#1632)

* Added option cleanup_tty to allow allocation when using sudo

* Added comment for new option cleanup_tty to CHANGELOG

* Added cleanup_use_sudo option to all commands in cleanup.php

* Fix return types for fluent interface (#1638)

* Add Prestashop 1.6 recipe (#1641)

* Add Prestashop 1.6 recipe

* Update changelog

* Sleep between process status calls to prevent 100% CPU usage (#1654)

* Sleep between progress status calls to prevent 100% CPU usage

* Add changelog entry

* Typo in changelog entry

* Update ParallelExecutor.php

* Update ParallelExecutor.php

* locate binary with less subprocesses (#1634)

* Set custom user for CI environments (#1659)

* Detect CI user

* Update CHANGELOG.md

* Update README.md

* [deploy:writable] chgrp doesn't need http_user (#1660)

* deploy:writable: chgrp doesn't need http_user

* Update CHANGELOG.md

* Add missing deploy:writable entries (#1662)

* Fix missing deploy:shared entries (#1664)

* Added Exception Handling for perhaps missing config param

Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it.

* style

* #1677 fixes according pull-request feedback

* #1677 code style fixes

* Added Exception Handling for perhaps missing config param

Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it.

* style

* #1677 fixes according pull-request feedback

* #1677 code style fixes

* Changelog entry for #1677

* Changelog entry for #1677

* Changelog entry for #1677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants