locate binary with less subprocesses #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
loc-binary
branch
5 times, most recently
from
0bdd8c0
to
3bab125
Compare
|
@antonmedv any feedback? |
|
Sorry, for delay. Will test it today and merge it. |
|
Ping |
antonmedv
pushed a commit
that referenced
this pull request
Aug 27, 2018
antonmedv
pushed a commit
that referenced
this pull request
Sep 5, 2018
* modify wrong ticket url (#1605) * moving the name column to the last position to show full name - bug fix: #1579 * add changelog * update changelog.md * update CHANGELOG.md * modify command to find http user * modify command to find http user * modify wrong ticket url * Remove magento:enable from Magento 2 recipe (#1606) * Remove magento:enable from Magento 2 recipe Magento's module states are stored in app/etc/config.php. This task ignored that and blindly enabled all installed modules. * Mention the removal of magento:enable in the changelog * Extend deploy:cleanup with tty allocation when using sudo. (#1607) * Added option cleanup_tty to allow allocation when using sudo * Added comment for new option cleanup_tty to CHANGELOG * Allow to set template path in Drupal 7 Settings recipe (#1613) * Change drupal:settings task to drupal:configure * Drupal 7 recipe - Set template file path * Changelog * Fixed once() tasks that where being run multiple times with ParallelE… (#1624) * Fixed once() tasks that where being run multiple times with ParallelExecutor * CHANGELOG: reorder issue * Add test case for parallel deploy on ->once() task * Added cleanup_use_sudo option to all commands in deploy:cleanup (#1632) * Added option cleanup_tty to allow allocation when using sudo * Added comment for new option cleanup_tty to CHANGELOG * Added cleanup_use_sudo option to all commands in cleanup.php * Fix return types for fluent interface (#1638) * Add Prestashop 1.6 recipe (#1641) * Add Prestashop 1.6 recipe * Update changelog * Sleep between process status calls to prevent 100% CPU usage (#1654) * Sleep between progress status calls to prevent 100% CPU usage * Add changelog entry * Typo in changelog entry * Update ParallelExecutor.php * Update ParallelExecutor.php * locate binary with less subprocesses (#1634) * Set custom user for CI environments (#1659) * Detect CI user * Update CHANGELOG.md * Update README.md * [deploy:writable] chgrp doesn't need http_user (#1660) * deploy:writable: chgrp doesn't need http_user * Update CHANGELOG.md * Add missing deploy:writable entries (#1662) * Fix missing deploy:shared entries (#1664) * Added Exception Handling for perhaps missing config param Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it. * style * #1677 fixes according pull-request feedback * #1677 code style fixes * Added Exception Handling for perhaps missing config param Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it. * style * #1677 fixes according pull-request feedback * #1677 code style fixes * Changelog entry for #1677 * Changelog entry for #1677 * Changelog entry for #1677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to optimize resource consumption.
before this change, the number of subprocesses required to locate a binary was 2 in the best case and 6 in the worst case.
after this change it always requires 1 process, no matter which command will be used at the end (whether
command -v,whichortype -p)