Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded deployer db_user and db_name in postgres provisioning #3319

Closed
wojciechczerniak opened this issue Sep 26, 2022 · 0 comments · Fixed by #3351
Closed

Hardcoded deployer db_user and db_name in postgres provisioning #3319

wojciechczerniak opened this issue Sep 26, 2022 · 0 comments · Fixed by #3351
Labels

Comments

@wojciechczerniak
Copy link

  • Deployer version: master
  • Deployment OS: Ubuntu 20 LTS

Although user is prompted for database user name, it's not used by Postgresql provisioning. deployer db_user and deployer db_name are hardcoded:

run('sudo -u postgres createuser deployer');
run('sudo -u postgres createdb deployer');

Shouldn't it be closer to this?

- run('sudo -u postgres createuser deployer'); 
- run('sudo -u postgres createdb deployer'); 
+ run('sudo -u postgres createuser {{db_user}}'); 
+ run('sudo -u postgres createdb {{db_name}}'); 
@antonmedv antonmedv added the bug label Sep 27, 2022
rafael-neris added a commit to rafael-neris/deployer that referenced this issue Oct 16, 2022
midweste pushed a commit to midweste/deployer that referenced this issue Oct 26, 2022
* origin/master: (40 commits)
  Laravel recipe: Skip database tasks if .env is missing (deployphp#3359)
  [automatic] Update docs with bin/docgen
  Add some notes on rsync --exclude option (deployphp#3350)
  Fix: deployphp#3319 - Receiving variables db_user and db_name (deployphp#3351)
  [automatic] Update docs with bin/docgen
  Remove default value for previous_release
  Escape metainfo to prevent bash syntax errors (deployphp#3328)
  [automatic] Update docs with bin/docgen
  Removed temporary workaround as it is for a version which is a year old (deployphp#3325)
  Feature/additional writable modes (deployphp#3316)
  Fix typo for SSH_KNOWN_HOSTS in CI/CD docs (deployphp#3310)
  Improve docs
  Update docs
  New recipes docs intro
  fix non-existing method (deployphp#3296)
  Update README.md
  Delete dependabot.yml
  [automatic] Update docs with bin/docgen
  Only delete symlink on broken release
  Remove validate config
  ...
schmengler pushed a commit to integer-net/deployer that referenced this issue Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants