Laravel recipe: Skip database tasks if .env is missing #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, this makes sense, thanks! |
midweste
pushed a commit
to midweste/deployer
that referenced
this pull request
Oct 26, 2022
* origin/master: (40 commits) Laravel recipe: Skip database tasks if .env is missing (deployphp#3359) [automatic] Update docs with bin/docgen Add some notes on rsync --exclude option (deployphp#3350) Fix: deployphp#3319 - Receiving variables db_user and db_name (deployphp#3351) [automatic] Update docs with bin/docgen Remove default value for previous_release Escape metainfo to prevent bash syntax errors (deployphp#3328) [automatic] Update docs with bin/docgen Removed temporary workaround as it is for a version which is a year old (deployphp#3325) Feature/additional writable modes (deployphp#3316) Fix typo for SSH_KNOWN_HOSTS in CI/CD docs (deployphp#3310) Improve docs Update docs New recipes docs intro fix non-existing method (deployphp#3296) Update README.md Delete dependabot.yml [automatic] Update docs with bin/docgen Only delete symlink on broken release Remove validate config ...
schmengler
pushed a commit
to integer-net/deployer
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?
As discussed here with @peterjaap, database tasks could be omitted if the .env file is missing on the Laravel recipe.
Before:
php artisan migrate=>Your .env file is empty! Skipping...✅php artisan migrate:rollback=> Crashes the deploy ❌After:
php artisan migrate=>Your .env file is empty! Skipping...✅php artisan migrate:rollback=>Your .env file is empty! Skipping...✅Let me know if you need me to add anything regarding documentation or tests.