Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user override phpunit locally. #1210

Merged
merged 1 commit into from May 15, 2017
Merged

Let user override phpunit locally. #1210

merged 1 commit into from May 15, 2017

Conversation

lucasmichot
Copy link
Contributor

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

@antonmedv
Copy link
Member

Why do you need it for?

@lucasmichot
Copy link
Contributor Author

A person contributing might tweak phpunit.xml file for different reasons: tweaking the test file, setup coverage or whatever.

When running vendor/bin/phpunit, if phpunit.xml exists it will be taken into consideration. Or else phpunit.xml.dist will be used.

See https://phpunit.de/manual/current/en/organizing-tests.html

@antonmedv
Copy link
Member

Why not tweak phpunit.xml itself then?

@lucasmichot
Copy link
Contributor Author

Because, if a developer change it, it would be commited

@antonmedv
Copy link
Member

Because, if a developer change it, it would be commited

Don't git add phpunit.xml :)

@lucasmichot
Copy link
Contributor Author

lucasmichot commented May 15, 2017

But it is not obvious
Have a look at .gitignore on https://github.com/symfony/symfony and https://github.com/laravel/framework

@antonmedv
Copy link
Member

Okay, lets merge it.

@antonmedv antonmedv merged commit 493b327 into deployphp:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants