-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added host() and port() to Builder #157
Conversation
Ok, is nice API. Please add tests to BuilderTest. |
@Elfet Done! 😄 |
HHVM tests fails today again. Reopened PR to process tests. |
@Elfet Yeah, lets wait. 😄 |
Added host() and port() to Builder
Done. |
@@ -31,7 +31,7 @@ | |||
* @param int $port | |||
* @return Builder | |||
*/ | |||
function server($name, $domain, $port = 22) | |||
function server($name, $domain = null, $port = 22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to update the docblock. string|null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 #189
This is just a proposal because i prefer more fluent like that:
instead of: