Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added host() and port() to Builder #157

Merged
merged 3 commits into from
Feb 15, 2015
Merged

Added host() and port() to Builder #157

merged 3 commits into from
Feb 15, 2015

Conversation

KennedyTedesco
Copy link
Contributor

This is just a proposal because i prefer more fluent like that:

server('name')
    ->host('ec2-52-171-208-37.my-server.com')
    ->port('9876')
    ->path('/home/dir/dir')
    ->user('user')
    ->pubKey('~/.ssh/name.pub', '~/.ssh/name');

instead of:

server('name', 'ec2-52-171-208-37.my-server.com', '9876')
    ->path('/home/dir/dir')
    ->user('user')
    ->pubKey('~/.ssh/name.pub', '~/.ssh/name');

@antonmedv
Copy link
Member

Ok, is nice API. Please add tests to BuilderTest.

@antonmedv antonmedv added this to the v3.0 milestone Feb 4, 2015
@KennedyTedesco
Copy link
Contributor Author

@Elfet Done! 😄

@antonmedv antonmedv closed this Feb 4, 2015
@antonmedv antonmedv reopened this Feb 4, 2015
@antonmedv
Copy link
Member

HHVM tests fails today again. Reopened PR to process tests.

@KennedyTedesco
Copy link
Contributor Author

@Elfet Yeah, lets wait. 😄

@antonmedv antonmedv closed this Feb 4, 2015
@antonmedv antonmedv reopened this Feb 4, 2015
@antonmedv antonmedv closed this Feb 5, 2015
@antonmedv antonmedv reopened this Feb 5, 2015
antonmedv pushed a commit that referenced this pull request Feb 15, 2015
Added host() and port() to Builder
@antonmedv antonmedv merged commit 721198f into deployphp:master Feb 15, 2015
@antonmedv
Copy link
Member

Done.

@@ -31,7 +31,7 @@
* @param int $port
* @return Builder
*/
function server($name, $domain, $port = 22)
function server($name, $domain = null, $port = 22)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the docblock. string|null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants