Check the exit status of the command instead of stderr #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer now outputs non-error messages to stderr. the `run` function should be check the exit status of the command, not the error output.
|
Cool. Thanks. Now work without errors? |
antonmedv
pushed a commit
that referenced
this pull request
Feb 26, 2015
Check the exit status of the command instead of stderr
|
Yep it was annoying but some applications use std error even though its not an error. Checking the exit status is a more reliable way to tell if the command was successful. 0 means Ok, any other number means there was an error |
|
Cool! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer now outputs non-error messages to stderr. The
runfunction should be check the exit status of the command, not the error output.