Fixes for check_remote task and SS recipe #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonom
force-pushed
the
fixes
branch
5 times, most recently
from
2fc84a1
to
9fd99aa
Compare
* Check remote head contents locally * Ensure .dep/HEAD file is available so error isn’t thrown * Document task usage Fixes deployphp#1990
* Additionally check shared directory for assets since this directory is commonly excluded from project git repos * Ensure shared_assets returns a non-null value so the release folder can’t get accidentally deleted Fixes deployphp#1989
Added a bug report template
|
I got a bit carried away and worked on some contribution meta stuff too. Looks like the important tests are passing and Scrutinizer is failing because of a configuration problem? |
|
Yes, you are right. Looks like configuration issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd normally submit two separate PRs but noted the request to update the changelog so have bundled them together and pre-emptively added a 6.7.4 entry. Hope that's okay!
I documented
check_remotetask usage in deploy-strategies.md but wasn't sure if this was the right place. Let me know if you want that moved.