Silverstripe recipe asset path broken #1989
Comments
jonom
added a commit
to jonom/deployer
that referenced
this issue
Jan 28, 2020
* Additionally check shared directory for assets since this directory is commonly excluded from project git repos * Ensure shared_assets returns a non-null value so the release folder can’t get accidentally deleted Fixes deployphp#1989
jonom
added a commit
to jonom/deployer
that referenced
this issue
Jan 28, 2020
* Additionally check shared directory for assets since this directory is commonly excluded from project git repos * Ensure shared_assets returns a non-null value so the release folder can’t get accidentally deleted Fixes deployphp#1989
jonom
added a commit
to jonom/deployer
that referenced
this issue
Jan 28, 2020
* Additionally check shared directory for assets since this directory is commonly excluded from project git repos * Ensure shared_assets returns a non-null value so the release folder can’t get accidentally deleted Fixes deployphp#1989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This commit broke Silverstripe deployment asset path for me, and I think probably for anyone who doesn't commit their asset folder to their git repo (which is convention).
If you don't have an assets folder in your repo then when
{{shared_assets}}is being evaluated here, the shared_assets callback returns null. This means that this command effectively runsrm -rf {{release_path}}which makes the deployment fail because the active release directory has been nuked.Fix incoming.
The text was updated successfully, but these errors were encountered: